SpecialFunctions.jl icon indicating copy to clipboard operation
SpecialFunctions.jl copied to clipboard

Added Fresnel integrals #398

Open curio-sitas opened this issue 2 years ago • 4 comments

Added Fresnel integrals from https://github.com/kiranshila/FresnelIntegrals.jl. As suggested in #398

Added 3 functions with docs :

  • Fresnelc(z)
  • Fresnels(z)
  • Fresnnel(z) = (Fresnelc(z),Fresnels(z))

Tests were added too

curio-sitas avatar Jul 11 '22 23:07 curio-sitas

Codecov Report

Merging #407 (08ed9e9) into master (36c547b) will increase coverage by 0.12%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   93.63%   93.76%   +0.12%     
==========================================
  Files          12       13       +1     
  Lines        2767     2822      +55     
==========================================
+ Hits         2591     2646      +55     
  Misses        176      176              
Flag Coverage Δ
unittests 93.76% <100.00%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SpecialFunctions.jl 100.00% <ø> (ø)
src/fresnel.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36c547b...08ed9e9. Read the comment docs.

codecov[bot] avatar Jul 11 '22 23:07 codecov[bot]

Added the last test for the function fresnel(z::Number) for full code coverage (codecov)

curio-sitas avatar Jul 14 '22 12:07 curio-sitas

Thanks for the review. I used to think it was a good idea to enrich the current package since it is a global SpecialFunctions collection.

I will take your reviews into account in my next commit and may open a PR on the original repo.

curio-sitas avatar Jul 15 '22 16:07 curio-sitas

  • Sign errors were corrected and some tests added (comparison with QuadGK.jl).

All above is also proposed in a PR on the original repo (FresnelIntegrals.jl).

curio-sitas avatar Jul 15 '22 22:07 curio-sitas

@curio-sitas I guess this PR can be closed now since the PR in FresnelIntegrals.jl was merged and released in version 0.2?

devmotion avatar Dec 12 '23 12:12 devmotion

Yes you can close it !

curio-sitas avatar Dec 12 '23 12:12 curio-sitas