MeasureTheory.jl
MeasureTheory.jl copied to clipboard
Gamma measure
Hey @cscherrer Here's the implementation of the Gamma measure based on the version from Distributions.jl, with both standard parametrizations from Wikipedia.
Thanks @gdalle . This is looking good, I think we just need a few more functions and some tests.
Weirdly, tests here are failing, for code that passed before, passes locally for me, and is completely outside your changes. I don't think there's anything for you to do about that, but I'll need to figure out what's going on.
EDIT: I figured it out! A test was incorrectly passing before I fixed some things in the last MeasureBase. I'll change it so it passes again.
Codecov Report
Merging #153 (0afa05c) into master (3928dfb) will decrease coverage by
0.53%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 33.81% 33.27% -0.54%
==========================================
Files 29 30 +1
Lines 556 565 +9
==========================================
Hits 188 188
- Misses 368 377 +9
Impacted Files | Coverage Δ | |
---|---|---|
src/MeasureTheory.jl | 50.00% <ø> (ø) |
|
src/parameterized/gamma.jl | 0.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3928dfb...0afa05c. Read the comment docs.
What kind of additional functions did you have in mind?
Sorry that was vague, the failing tests had me pretty distracted. Offhand I didn't see a method for testvalue
. We'll also need some tests. Could you add some similar to other parameterized measures? These are in test/runtests.jl
. In general we really need to improve our test coverage.
Thanks again for your work on this :)