MeasureBase.jl icon indicating copy to clipboard operation
MeasureBase.jl copied to clipboard

Fix `Vararg` warnings

Open cscherrer opened this issue 1 year ago • 6 comments

In Julia 1.10 beta (at least) we get this warning a lot:

│  WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
│  You may need to write `f(x::Vararg{T})` rather than `f(x::Vararg{<:T})` or `f(x::Vararg{T}) where T` instead of `f(x::Vararg{T} where T)`.

Here Simeon Schaub suggests that to address this, "Just use Vararg{Number} instead of Vararg{<:Number}". This PR makes this small change

cscherrer avatar Aug 04 '23 22:08 cscherrer

Package name latest stable
MeasureTheory.jl

github-actions[bot] avatar Aug 04 '23 22:08 github-actions[bot]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (609a2bd) 55.55% compared to head (d745078) 55.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           mt-015     #123   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files          42       42           
  Lines        1179     1179           
=======================================
  Hits          655      655           
  Misses        524      524           
Files Changed Coverage Δ
src/combinators/smart-constructors.jl 24.69% <ø> (ø)
src/combinators/power.jl 82.25% <100.00%> (ø)
src/static.jl 80.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 04 '23 22:08 codecov[bot]

I have this in #122 already, I think - if it's ok I'd hold off until that done (hopefully very soon) to reduce merge conflicts.

oschulz avatar Aug 04 '23 23:08 oschulz

I don't think so, the pr targets that branch

cscherrer avatar Aug 05 '23 00:08 cscherrer

OTOH no problem waiting if you prefer, it's pretty minor I think

cscherrer avatar Aug 05 '23 01:08 cscherrer

Thanks - I'll get back to that monster-PR, promise!

oschulz avatar Aug 05 '23 17:08 oschulz

Included in #142

oschulz avatar Sep 09 '24 12:09 oschulz