Interpolations.jl icon indicating copy to clipboard operation
Interpolations.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaMath

Gridded Cubic Splines (WIP)

Open alexmorley opened this issue 7 years ago • 9 comments

Very much work in progress! Allows cubic spline interpolation for a uneven grid.

Currently just a 1-D implementation with natural spline boundary conditions that I made for an Empirical Mode Decomposition package I am writing (seemed a shame to have to rely on Fortran's DIERCKX).

To Do (probably in the next week or two):

  • [ ] Add periodic, not-a-knot and quadratic boundary conditions
  • [ ] Re-write using generated functions for perf + multi-dimensional interpolations
  • [ ] Tests!
  • Anything else?

Submitting PR now to avoid duplication or if anyone fancies to help :smile:

alexmorley avatar Feb 19 '18 14:02 alexmorley

Very interested to know how this is coming along.

Edit: I tested it out. Once I figured out that the correct call was Gridded(Cubic(Reflect())), everything seemed to work ok. In my current setting, performance diff vs gridded linear is not noticeable.

tbeason avatar Mar 07 '18 18:03 tbeason

I take it back. I didn't see you said that your implementation was for Natural boundary conditions. Gridded(Cubic(Natural())) does not work. Only Gridded(Cubic(Reflect())) gives me anything, which is weird. It looks like you defined some methods for each, but not all methods for either.

tbeason avatar Mar 08 '18 23:03 tbeason

This functionality would be great! Any update on this?

lungben avatar Mar 01 '20 10:03 lungben

It did not make it in before the giant rewrite in #226. It would have to be totally redone. But it should be much easier now that we're not using generated functions for everything. Want to take a crack at it, @lungben? Basically everything that gets added here is added by someone who needs it, and you're the latest!

timholy avatar Mar 01 '20 11:03 timholy

@timholy thanks for the update! I will take a look, but it probably will take a while and I probably will have to ask stupid questions ;-)

lungben avatar Mar 01 '20 12:03 lungben

That would be fine! The place to start is the new WeightedIndex infrastructure. That, prefiltering, and the code to calculate the right indexing/weighting are really the pillars of the package.

timholy avatar Mar 01 '20 12:03 timholy

I did not had the time yet to get into this topic, and probably will not have the time for it in the near future. Sorry for that!

lungben avatar May 23 '20 20:05 lungben