MLDatasets.jl icon indicating copy to clipboard operation
MLDatasets.jl copied to clipboard

Add Faust Dataset

Open Dsantra92 opened this issue 2 years ago • 8 comments

Closes #155

Dsantra92 avatar Jul 25 '22 12:07 Dsantra92

The unit test is causing problems because it cannot download from UCI archives.

Dsantra92 avatar Jul 25 '22 14:07 Dsantra92

@CarloLucibello should we remove the failing changes? I believe the CI downloading dataset is most likely flagged as bot download.

Dsantra92 avatar Jul 26 '22 19:07 Dsantra92

I'm not sure why we have an error with the PTBLM dataset that we didn't have before, but we can remove it from the CI tests and open a corresponding issue tracking the problem

CarloLucibello avatar Jul 26 '22 19:07 CarloLucibello

I'm not sure why we have an error with the PTBLM dataset that we didn't have before, but we can remove it from the CI tests and open a corresponding issue tracking the problem

CarloLucibello avatar Jul 26 '22 19:07 CarloLucibello

I'm not sure why we have an error with the PTBLM dataset that we didn't have before, but we can remove it from the CI tests and open a corresponding issue tracking the problem

Cool

Dsantra92 avatar Jul 26 '22 19:07 Dsantra92

Codecov Report

Merging #160 (eb0108d) into master (66edbf7) will decrease coverage by 1.59%. The diff coverage is 10.34%.

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   33.62%   32.03%   -1.60%     
==========================================
  Files          40       42       +2     
  Lines        2028     2132     +104     
==========================================
+ Hits          682      683       +1     
- Misses       1346     1449     +103     
Impacted Files Coverage Δ
src/datasets/meshes/faust.jl 2.17% <2.17%> (ø)
src/abstract_datasets.jl 21.87% <22.22%> (-0.71%) :arrow_down:
src/MLDatasets.jl 100.00% <100.00%> (ø)
src/datasets/text/smsspamcollection.jl 7.69% <0.00%> (-44.16%) :arrow_down:
src/datasets/graphs/polblogs.jl 84.21% <0.00%> (-5.27%) :arrow_down:
src/datasets/vision/emnist.jl 5.00% <0.00%> (-5.00%) :arrow_down:
src/datasets/graphs/reddit.jl 2.12% <0.00%> (-2.13%) :arrow_down:
src/datasets/graphs/tudataset.jl 1.36% <0.00%> (-1.37%) :arrow_down:
src/datasets/vision/cifar10.jl 1.20% <0.00%> (-1.21%) :arrow_down:
src/datasets/vision/cifar100.jl 1.20% <0.00%> (-1.21%) :arrow_down:
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 28 '22 05:07 codecov-commenter

the 1.6 test failure seems real. Not sure which escape sequence is invalid on julia 1.6 though

CarloLucibello avatar Aug 02 '22 09:08 CarloLucibello

The problem is backslashes in lines 36-42 breaking two lines. Breaklines compatibility changed in 1.7 as understood from this discourse thread. It would be better to just use longer lines for now to let all the tests pass.

Dsantra92 avatar Aug 02 '22 16:08 Dsantra92

The problem is backslashes in lines 36-42 breaking two lines. Breaklines compatibility changed in 1.7 as understood from this discourse thread. It would be better to just use longer lines for now to let all the tests pass.

can we do this and complete this PR?

CarloLucibello avatar Sep 01 '22 08:09 CarloLucibello

Version Bump for this :0

Dsantra92 avatar Oct 01 '22 18:10 Dsantra92