MLDataUtils.jl icon indicating copy to clipboard operation
MLDataUtils.jl copied to clipboard

Propose some changes to DataFrames.jl API

Open bkamins opened this issue 3 years ago • 4 comments

I will comment on the rationale of the changes inline (as I might not understand all the details of the intended design).

bkamins avatar Sep 14 '21 21:09 bkamins

CI is failing because only is not defined in Julia 1.0 but this can be fixed later after we confirm the design intention.

bkamins avatar Sep 14 '21 22:09 bkamins

Looks okay to me. Since I don't use DF very much, @oxinabox how does this look to you?

johnnychen94 avatar Sep 17 '21 03:09 johnnychen94

Seems right to me though I haven't looked at LearnBase in literally years, and doing #46 seems like a better idea, but this is a net improvement.

oxinabox avatar Sep 18 '21 10:09 oxinabox

Ah - I have not seen #46. Indeed this PR should be closed if someone is working on #46.

bkamins avatar Sep 18 '21 11:09 bkamins