IterativeSolvers.jl icon indicating copy to clipboard operation
IterativeSolvers.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaLinearAlgebra

Bring back 5-arg `mul!` to lsmr

Open haampie opened this issue 7 years ago • 4 comments

In #205 I have temporarily removed the 5-argument mul!(y, A, x, a, b) calls from lsmr, since there is no implementation for dense A. It worked becauselsmr implemented it itself, but I guess nobody wants IterativeSolvers.jl to extend LinearAlgebra.mul!.

Let's wait till we have the 5-argument mul! in LinearAlgebra and bring it back to lsmr only then.

haampie avatar Jul 09 '18 13:07 haampie

Not sure this is ever coming back. We may want to consider using LinearAlgebra.BLAS.gemv! instead.

lostella avatar Apr 05 '19 20:04 lostella

Please avoid calling the BLAS wrappers directly if possible. It would be better to call a generic version.

andreasnoack avatar Apr 05 '19 20:04 andreasnoack

it is endlessly frustrating that we don't have an efficient generic in-place 5 argument mul! in Julia

chriscoey avatar Jun 18 '19 03:06 chriscoey

https://github.com/JuliaLang/julia/pull/29634 has been merged (huzzah!) hence we can now use 5-arg mul!

chriscoey avatar Aug 15 '19 17:08 chriscoey