GenericSVD.jl icon indicating copy to clipboard operation
GenericSVD.jl copied to clipboard

Deprecate in favor of GenericLinearAlgebra.jl?

Open simonbyrne opened this issue 4 years ago • 8 comments

The code in this package was originally a slightly cleaned up version of @andreasnoack's code in GenericLinearAlgebra.jl (which at that point was an unregistered package called LinearAlgebra.jl, predating the stdlib of the same name). I haven't really done much with this package since its creation, other than merging version upgrades and obvious bug fixes (thanks to the contributors!), and GenericLinearAlgebra.jl is now a registered and more complete package. There are also some issues with the packages type piracy causing conflicts (see https://github.com/JuliaLinearAlgebra/GenericLinearAlgebra.jl/pull/71).

Are there any opinions on deprecating this package in favor of GenericLinearAlgebra.jl? The currently registered direct dependencies are:

  • OrdinaryDiffEq.jl (cc @ChrisRackauckas @YingboMa)
  • DoubleFloats.jl and ArbNumercs.jl (cc @JeffreySarnoff)

simonbyrne avatar Mar 26 '21 04:03 simonbyrne

Actually, it looks like OrdinaryDiffEq.jl no longer depends on this https://github.com/SciML/OrdinaryDiffEq.jl/pull/1356?

simonbyrne avatar Mar 26 '21 04:03 simonbyrne

Any thoughts @RalphAS @matbesancon?

simonbyrne avatar Mar 26 '21 04:03 simonbyrne

Seems like the main missing bit of functionality in GenericLinearAlgebra is the full keyword (https://github.com/JuliaLinearAlgebra/GenericLinearAlgebra.jl/issues/20#issuecomment-749493210) added by @olof3.

simonbyrne avatar Mar 26 '21 05:03 simonbyrne

Agreed to deprecate it for GenericLinearAlgebra

matbesancon avatar Mar 26 '21 10:03 matbesancon

It has been handy to have a separate SVD for compatibility with GenericSchur. I have recently tried to make the latter compatible with GenericLinearAlgebra; if that effort is successful then I can agree.

RalphAS avatar Mar 26 '21 13:03 RalphAS

that is sane

JeffreySarnoff avatar Mar 26 '21 13:03 JeffreySarnoff

It has been handy to have a separate SVD for compatibility with GenericSchur. I have recently tried to make the latter compatible with GenericLinearAlgebra; if that effort is successful then I can agree.

Wouldn't it be good to merge the GenericSchur functionality into GenericLinearAlgebra as well? Or is that what you are referring to?

olof3 avatar Mar 26 '21 14:03 olof3

Okay, now that GenericLinearAlgebra is at feature parity, I am going to deprecate this package.

simonbyrne avatar Mar 30 '21 04:03 simonbyrne