Implement vcat(::AbstractBandedMatrix...)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.93%. Comparing base (
47c15ab) to head (9e8706b). Report is 8 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 89.61% 89.93% +0.32%
==========================================
Files 25 25
Lines 3571 3675 +104
==========================================
+ Hits 3200 3305 +105
+ Misses 371 370 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've had a lot of issues involving randomly generated banded matrices where one or both of the bandwidths exceed the dimensions of a matrix (e.g a 2x2 BandedMatrix with bandwidths (4,3)). Is it worth adding something in the constructors that clamps l and u between -m and n-1 and -n and m-1 respectively?
No because having more bands than the dimension is permitted
I would recommend not using random bandwidths in the unit tests