BandedMatrices.jl icon indicating copy to clipboard operation
BandedMatrices.jl copied to clipboard

Implement vcat(::AbstractBandedMatrix...)

Open max-vassili3v opened this issue 1 year ago • 1 comments

max-vassili3v avatar Jul 18 '24 18:07 max-vassili3v

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.93%. Comparing base (47c15ab) to head (9e8706b). Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   89.61%   89.93%   +0.32%     
==========================================
  Files          25       25              
  Lines        3571     3675     +104     
==========================================
+ Hits         3200     3305     +105     
+ Misses        371      370       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 18 '24 18:07 codecov[bot]

I've had a lot of issues involving randomly generated banded matrices where one or both of the bandwidths exceed the dimensions of a matrix (e.g a 2x2 BandedMatrix with bandwidths (4,3)). Is it worth adding something in the constructors that clamps l and u between -m and n-1 and -n and m-1 respectively?

max-vassili3v avatar Jul 19 '24 20:07 max-vassili3v

No because having more bands than the dimension is permitted

I would recommend not using random bandwidths in the unit tests

dlfivefifty avatar Jul 19 '24 20:07 dlfivefifty