ArrayLayouts.jl icon indicating copy to clipboard operation
ArrayLayouts.jl copied to clipboard

`(row|col)support(A, ::CartesianIndex{2})`

Open putianyi889 opened this issue 1 year ago • 5 comments

putianyi889 avatar Nov 27 '23 09:11 putianyi889

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d44e944) 87.47% compared to head (a707be0) 87.48%. Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   87.47%   87.48%   +0.01%     
==========================================
  Files          11       11              
  Lines        1812     1814       +2     
==========================================
+ Hits         1585     1587       +2     
  Misses        227      227              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 27 '23 09:11 codecov[bot]

Why is this needed?

dlfivefifty avatar Nov 27 '23 14:11 dlfivefifty

for convenience

putianyi889 avatar Nov 27 '23 14:11 putianyi889

The issue is that it introduces ambiguities, for example

https://github.com/JuliaArrays/LazyArrays.jl/blob/7a9603201d30ec87f6dd5ce3b9a4715b1410599b/src/linalg/mul.jl#L178

dlfivefifty avatar Nov 28 '23 10:11 dlfivefifty

How about that being

rowsupport(::ApplyLayout{typeof(*)}, B, j) = _mul_rowsupport(j, B.args...)

putianyi889 avatar Nov 28 '23 11:11 putianyi889