ArrayLayouts.jl
ArrayLayouts.jl copied to clipboard
`(row|col)support(A, ::CartesianIndex{2})`
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d44e944
) 87.47% compared to head (a707be0
) 87.48%. Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 87.47% 87.48% +0.01%
==========================================
Files 11 11
Lines 1812 1814 +2
==========================================
+ Hits 1585 1587 +2
Misses 227 227
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why is this needed?
for convenience
The issue is that it introduces ambiguities, for example
https://github.com/JuliaArrays/LazyArrays.jl/blob/7a9603201d30ec87f6dd5ce3b9a4715b1410599b/src/linalg/mul.jl#L178
How about that being
rowsupport(::ApplyLayout{typeof(*)}, B, j) = _mul_rowsupport(j, B.args...)