ArrayLayouts.jl icon indicating copy to clipboard operation
ArrayLayouts.jl copied to clipboard

Hotfix some direct solve ambiguities

Open termi-official opened this issue 1 year ago • 2 comments

Hotfix as proposed in https://github.com/JuliaArrays/BlockArrays.jl/issues/319

termi-official avatar Nov 10 '23 15:11 termi-official

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d44e944) 87.47% compared to head (300ceaf) 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #181       +/-   ##
==========================================
- Coverage   87.47%   0.00%   -87.48%     
==========================================
  Files          11      11               
  Lines        1812    1712      -100     
==========================================
- Hits         1585       0     -1585     
- Misses        227    1712     +1485     
Files Coverage Δ
src/ldiv.jl 0.00% <0.00%> (-90.56%) :arrow_down:
ext/ArrayLayoutsSparseArraysExt.jl 0.00% <0.00%> (-100.00%) :arrow_down:

... and 9 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 10 '23 15:11 codecov[bot]

I am still lost why only the WY form has issues, but this PR should fix it. Plus it fixes ambiguities with some sparse direct solve dispatches.

termi-official avatar Nov 10 '23 18:11 termi-official