ArrayLayouts.jl icon indicating copy to clipboard operation
ArrayLayouts.jl copied to clipboard

Rename _copyto! as copyto_layout!

Open dlfivefifty opened this issue 1 year ago • 2 comments

I think a more descriptive name would be good here.

dlfivefifty avatar Jul 26 '23 10:07 dlfivefifty

Bikeshedding, but should this be layout_copyto! to be consistent with layout_getindex? Personally, I prefer this function_layout naming style, but renaming layout_getindex might require considerable changes across the ecosystem.

jishnub avatar Aug 02 '23 14:08 jishnub

I don't think its considerable changes to do layout_getindex -> getindex_layout since thats only ever called, never overloaded.

dlfivefifty avatar Aug 02 '23 15:08 dlfivefifty