ArnoldiMethod.jl icon indicating copy to clipboard operation
ArnoldiMethod.jl copied to clipboard

Preallocate workspace

Open samuelpowell opened this issue 4 years ago • 2 comments

I've been using this package to solve a very large number of small eigenproblems in parallel. Owing to the large number of solves my runtime was dominated by allocation, so I had to factor out the allocation routines in the partial Schur factorisation.

The PR is a draft as I haven't tested it beyond my own requirements.

If this is of use to a wider audience, I'm happy to clean it up as required. If not, I'm equally happy to close it and maintain a fork.

P.S. Performance is excellent, thanks for your work on this @haampie .

samuelpowell avatar Jun 10 '20 14:06 samuelpowell

This is a very welcome PR! It is also a step in the direction of making the algorithm work with different array types. I'll review it a bit later!

haampie avatar Jun 10 '20 14:06 haampie

Thanks @haampie , seems to pass tests so I'll udraft it.

samuelpowell avatar Jun 10 '20 14:06 samuelpowell

This is a very welcome PR! It is also a step in the direction of making the algorithm work with different array types. I'll review it a bit later!

That did not happen, but I'll add you as a Co-authored-by in #141

haampie avatar Feb 20 '24 22:02 haampie