www.julialang.org icon indicating copy to clipboard operation
www.julialang.org copied to clipboard

Published 20 hours ago • verified publisher icon JuliaLang

A few minor a11y and other issues

Open amellnik opened this issue 5 years ago • 8 comments
trafficstars

I noticed a few minor issues when looking at the draft website, some (all?) of which are probably common to the previous version. I don't think any are blocking.

  • [ ] Text in top nav link has borderline contrast, and when the user hovers over the nav bar item the contrast drops to 3.91:1.
  • [ ] No change in visual style when the star portion of the github badge is tab-focused.
  • [ ] Contract is not great on the tab selectors (like under Ecosystem).
  • [ ] Revise logo is smooshed under essential tools.
  • [ ] Donate button at the top has almost invisible style change on focus. Donate button on the bottom is better.
  • [x] Italic issue in NumFOCUS paragraph at /jsoc
  • [ ] For most pages the nav item at the top gets a red underline when the user is on the page, but not for /jsoc
  • [ ] The grey alert at the top about Prof Edelman's talk seems like it should have a button to hide it.
  • [ ] Dates for blog posts have low contrast.
  • [ ] Lots of images without alt set (I can help fill these in later).

I haven't tried it with a screen reader yet but will give it a spin tomorrow. Let me know if I should file this in the main website repo instead.

amellnik avatar Jan 08 '20 04:01 amellnik

Awesome feedback. I used Tota11y (create by Khan Academy) and seemed to resolve all the warnings it had. What sort of software are you using to get these suggestions? I am unclear right now what the status of this repo and the other Pull Request are.

logankilpatrick avatar Jan 08 '20 17:01 logankilpatrick

Thanks, this is very useful. But this doesn't seem to block https://github.com/JuliaLang/www.julialang.org/pull/544 so maybe this can be done post merge.

abhishalya avatar Jan 11 '20 06:01 abhishalya

Yeah, that’s what Alex said too. We can tackle this after the merge.

logankilpatrick avatar Jan 11 '20 12:01 logankilpatrick

The new and squarier Revise logo is ready to go (https://github.com/timholy/Revise.jl/pull/413) but I thought it would be better to wait until the dust has settled a bit.

cormullion avatar Jan 11 '20 17:01 cormullion

@cormullion We can get the new revise logo in.

ViralBShah avatar Jan 12 '20 06:01 ViralBShah

Bump? (https://github.com/timholy/Revise.jl/pull/413#issuecomment-582077222)

cormullion avatar Feb 04 '20 19:02 cormullion

This should be updated.

  1. This seems not to be an issue anymore:

For most pages the nav item at the top gets a red underline when the user is on the page, but not for /jsoc

  1. Blog post dates have regularcontrast... since they're just black text on white background?
  2. Donate buttons are the same
  3. GitHub's star badge does change on focus

Regarding 3. and 4, those are just buttons provided by GitHub. It's not really something made specifically for julialang.org.

zlatanvasovic avatar May 14 '20 11:05 zlatanvasovic

It would be good to go through and do an alt text audit. That seems like it should be simple to do. Also, if we can have a CI give a warning on images that lack alt text that'd be great to keep up quality.

Keno avatar Feb 24 '21 19:02 Keno