julia icon indicating copy to clipboard operation
julia copied to clipboard

Backports for 1.11.2

Open KristofferC opened this issue 1 year ago • 1 comments

Backported PRs:

  • [x] #55886
  • [x] #55867
  • [x] #56084
  • [x] #56088
  • [x] #54093
  • [x] #56165
  • [x] #56148
  • [x] #56174
  • [x] #56159
  • [x] #56089
  • [x] #56195
  • [x] #56215

Need manual backport:

  • [ ] #55908
  • [ ] #56097

Contains multiple commits, manual intervention needed:

  • [ ] #55877
  • [ ] #55802
  • [x] #55741

Non-merged PRs with backport label:

  • [x] #56227
  • [ ] #56214
  • [ ] #56156
  • [ ] #56149
  • [x] #56092
  • [ ] #55958
  • [ ] #55956
  • [ ] #55910
  • [ ] #55871
  • [x] #55870
  • [ ] #55813
  • [ ] #55534
  • [ ] #55499
  • [ ] #55458
  • [ ] #55457
  • [ ] #55220
  • [ ] #55169
  • [ ] #54457
  • [ ] #53957
  • [ ] #51479
  • [ ] #50813
  • [ ] #50157

KristofferC avatar Oct 18 '24 10:10 KristofferC

I tried to cherry-pick https://github.com/JuliaLang/julia/pull/56214 here but it's a bit tricky because precompilepkgs has changed a fair bit with the workspaces support, which isn't on 1.11. (I did add two minor backports that help reduce the merge conflicts though.) I highlight that as I think it's something we'd want to get in here. cc. @vtjnash

IanButterworth avatar Oct 20 '24 02:10 IanButterworth

@IanButterworth, I attempted a cherry-pick as well. It seems to work ok.

KristofferC avatar Oct 21 '24 11:10 KristofferC

@maleadt, seems like the llvmpasses test fails after backporting https://github.com/JuliaLang/julia/pull/56228/commits/9c94a386914d330f04a602a3aa9adf9ee9512979

KristofferC avatar Oct 21 '24 12:10 KristofferC

@nanosoldier runtests()

KristofferC avatar Oct 22 '24 15:10 KristofferC

@nanosoldier runbenchmarks(ALL, vs=":release-1.11")

KristofferC avatar Oct 22 '24 15:10 KristofferC

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

nanosoldier avatar Oct 22 '24 22:10 nanosoldier

The package evaluation job you requested has completed - possible new issues were detected. The full report is available.

nanosoldier avatar Oct 23 '24 17:10 nanosoldier

@nanosoldier runtests(["FloatTracker", "BracedErrors", "EulerAngles", "JuliaSyntaxHighlighting", "Cosmology", "NeighbourLists", "CharacteristicInvFourier", "DiffusionMap", "FindMinimaxPolynomial", "GigaSOM", "MIRT", "SwitchOnSafety", "QSFit", "TMLE", "Simpsons", "IncompressibleNavierStokes"])

KristofferC avatar Oct 23 '24 18:10 KristofferC

The package evaluation job you requested has completed - possible new issues were detected. The full report is available.

nanosoldier avatar Oct 23 '24 19:10 nanosoldier

julia> using JuliaInterpreter, BracedErrors

julia> bracederror(2.34567e70, 3.46e69) == @interpret bracederror(2.34567e70, 3.46e69)
false

Maybe some fast math stuff?

Edit: Bisected to #55802

Minimized to

julia> 10.0^68 # PR
1.0000000000000001e68

julia> 10.0^68 # 1.11.1
1.0e68

KristofferC avatar Oct 24 '24 08:10 KristofferC

@nanosoldier runtests(["BracedErrors", "JuliaSyntaxHighlighting", "Cosmology", "NeighbourLists", "QSFit", "SwitchOnSafety", "IncompressibleNavierStokes"])

KristofferC avatar Oct 24 '24 09:10 KristofferC

The package evaluation job you requested has completed - possible new issues were detected. The full report is available.

nanosoldier avatar Oct 24 '24 10:10 nanosoldier

Please add my trivial printing speed-optimization #56331 (was this larger approved speed-optimization #56308) to this.

And this bug-fix #56340 to get interop with R to work after 1.11 broke it.

Also add this bug-fix #56278?

PallHaraldsson avatar Oct 24 '24 11:10 PallHaraldsson

@nanosoldier runtests()

KristofferC avatar Nov 01 '24 13:11 KristofferC

The package evaluation job you requested has completed - possible new issues were detected. The full report is available.

nanosoldier avatar Nov 02 '24 05:11 nanosoldier

Okay, let's run another PkgEval and then not merge too much in here so we can fix the possible regressions and get this out.

@nanosoldier runtests()

KristofferC avatar Nov 11 '24 12:11 KristofferC

The package evaluation job you requested has completed - possible new issues were detected. The full report is available.

nanosoldier avatar Nov 11 '24 23:11 nanosoldier

I think the latest backport should fix Revise

KristofferC avatar Nov 12 '24 13:11 KristofferC

@nanosoldier runtests(["JuliaSyntaxHighlighting", "JuliaInterpreter", "LogDensityProblemsAD", "Revise", "FromFile", "Handcalcs", "CharacteristicInvFourier", "BenchmarkProfiles", "AxisKeysExtra", "RegressionTables", "ExtendableGrids", "MCVI", "StipplePlotly", "StipplePlotlyExport", "NonconvexMultistart", "PlutoPages", "ParticleInCell", "DistributedFactorGraphs", "WaveSpec", "FrequencySweep", "SpiDy"])

KristofferC avatar Nov 12 '24 13:11 KristofferC

Is https://github.com/JuliaLang/julia/issues/56077 fixed on this with the latest backports?

IanButterworth avatar Nov 12 '24 13:11 IanButterworth

Doesn't look like it, the PR that fixes it seems quite big to backport...

KristofferC avatar Nov 12 '24 14:11 KristofferC

Kristoffer in another PR (but intended for here):

looks like JuliaSyntaxHighligting needs updating to work with this.

JuliaSyntaxHighligting shouldn't be included as a 1.11 stdlib though? Unless you're talking about the general-released package, which indeed needs me to backport the changes to a new release.

tecosaur avatar Nov 12 '24 15:11 tecosaur

Unless you're talking about the general-released package, which indeed needs me to backport the changes to a new release.

Yes.

KristofferC avatar Nov 12 '24 15:11 KristofferC

Before releasing v1.11.2, i.e., after we merge this here, we should first merge https://github.com/JuliaSparse/SparseArrays.jl/pull/571 and then bump SparseArrays.jl on the release-v1.11 branch.

dkarrasch avatar Nov 12 '24 21:11 dkarrasch

The package evaluation job you requested has completed - possible new issues were detected. The full report is available.

nanosoldier avatar Nov 13 '24 12:11 nanosoldier