julia icon indicating copy to clipboard operation
julia copied to clipboard
verified publisher icon JuliaLang

Testing unstable ssa values useref values in red

Open joseeloren opened this issue 1 year ago • 3 comments

I have made some tests to check if unstable ssa values useref values are in red. This address issue #54028 PRs: #54501 and #54441. The last one is #54501, that is waiting for these tests.

@gbaraldi

joseeloren avatar Aug 09 '24 16:08 joseeloren

@gbaraldi @Zentrik @fingolfin

joseeloren avatar Aug 14 '24 18:08 joseeloren

I think it's almost there but looking at it in my terminal it seems we are printing the SSA values in a slightly different colour image I believe it should use :light_redand also bold. Following emphasize thats used in https://github.com/JuliaLang/julia/blob/db25494f62b78372c745053dc2a0644847bfab33/stdlib/InteractiveUtils/src/codeview.jl#L30-L43

gbaraldi avatar Aug 15 '24 13:08 gbaraldi

You are right @gbaraldi Fixed.

joseeloren avatar Aug 16 '24 17:08 joseeloren

Bump @topolarity @fingolfin @gbaraldi . I think this is just waiting for some reaction from your side to the authors changes and responses to your comments in this PR and in https://github.com/JuliaLang/julia/pull/54501.

And it would be great to get this in 1.12 (aka merged until tomorrow)

lgoettgens avatar Jan 07 '25 14:01 lgoettgens

The main obstacle here seems to be the conflicts this PR has which somebody needs to resolve before merging is an option?

fingolfin avatar Jan 07 '25 16:01 fingolfin