julia icon indicating copy to clipboard operation
julia copied to clipboard

Revert "inference: implement an opt-in interface to cache generated sources"

Open vtjnash opened this issue 1 year ago • 2 comments

Reverts JuliaLang/julia#54916

vtjnash avatar Jun 28 '24 19:06 vtjnash

Is the GC issue you mentioned post merge unfixable?

oscardssmith avatar Jun 28 '24 20:06 oscardssmith

Yes, it is a missing gc_wb that cannot be added to that design

vtjnash avatar Jun 28 '24 20:06 vtjnash

Yes, it is a missing gc_wb that cannot be added to that design

Would adding some sort of GC annotation to jl_code_for_staged solve the issue, or is a larger refactor likely needed? In the package I'm currently trying to implement, using Core.CachedGenerator is expected to significantly improve performance, so I would like to know how to correctly implement Core.CachedGenerator.

aviatesk avatar Jul 01 '24 05:07 aviatesk

I am not really sure what that parameter does. It seems already very suspicious and sketchy that a function that is defined to be a pure transform of input arguments to CodeInfo is returning something that is mutable

vtjnash avatar Jul 07 '24 19:07 vtjnash