julia icon indicating copy to clipboard operation
julia copied to clipboard

RFC: Make `include_dependency(path; track_content=true)` the default

Open fatteneder opened this issue 1 year ago • 6 comments

By changing the default to true we make it easier to build relocatable packages from already existing ones when 1.11 lands.

This keyword was just added during 1.11, so its not yet too late to change its default.

fatteneder avatar Jun 27 '24 19:06 fatteneder

I am in favor of this. But to double check if the file doesn't exist this will throw an error? Previously it would not?

Well spotted. Although that was a consequence of #53286 and not changing the default.

I added a note.

fatteneder avatar Jun 27 '24 19:06 fatteneder

@KristofferC your thoughts since it is late in the cycle?

vchuravy avatar Jun 28 '24 18:06 vchuravy

@nanosoldier runtests(ALL, vs = ":master")

vchuravy avatar Jun 28 '24 18:06 vchuravy

The package evaluation job you requested has completed - possible new issues were detected. The full report is available.

nanosoldier avatar Jun 29 '24 05:06 nanosoldier

PkgEval looks good. But just to be sure.

@nanosoldier runtests(["EarlyStopping", "BlockBandedMatrices", "FiniteDiff", "Pyehtim", "StatisticalProcessMonitoring", "OptimizationPRIMA", "DECAES", "OptimizationOptimJL", "PEPSKit", "LongwaveModePropagator", "ODEProblemLibrary", "GeneralizedSasakiNakamura", "NonconvexBayesian", "PGFPlots", "ConceptualClimateModels", "AdaptiveTestPlots", "SMLMSim", "TulipaPlots", "OVERT", "RetentionParameterEstimator"], vs = ":master")

fatteneder avatar Jun 29 '24 09:06 fatteneder

The package evaluation job you requested has completed - no new issues were detected. The full report is available.

nanosoldier avatar Jun 29 '24 10:06 nanosoldier

Note that this fix is needed when Julia application is bundled into MSIX archive as makeappx sets mtime of all files when they are put into the archive. For my situation an alternative is submitting pull requests to ConstructionBase, CxxWrap, ExceptionUnwrapping, Infiltrator and RelocatableFolders.

I am also considering applying a regex for include_dependecy after bundling in AppBudler but I would prefer using a nightly 1.11 bundle with this change in JuliaCon presentation demo part.

JanisErdmanis avatar Jul 02 '24 08:07 JanisErdmanis

I am going to merge this for now and defer the backport decision to Kristoffer.

vchuravy avatar Jul 02 '24 17:07 vchuravy