julia icon indicating copy to clipboard operation
julia copied to clipboard

Dead link in documentation

Open GHTaarn opened this issue 1 year ago • 3 comments

On https://docs.julialang.org/en/v1/stdlib/Test/

the link to https://pkgdocs.julialang.org/dev/creating-packages/#Adding-tests-to-the-package does not work. The link has the text "adding tests to your Julia Package"

GHTaarn avatar Feb 15 '24 15:02 GHTaarn

It points to dev whereas the link should probably be the v1 link that works here: https://pkgdocs.julialang.org/v1/creating-packages/#Adding-tests-to-the-package

sjkelly avatar Feb 15 '24 17:02 sjkelly

Thank you, that looks correct

GHTaarn avatar Feb 15 '24 17:02 GHTaarn

Submit a PR?

ViralBShah avatar Feb 16 '24 14:02 ViralBShah

Hello, Is this issue closed? Or can I work on it?

areebfazli avatar Feb 29 '24 12:02 areebfazli

Welcome, it still needs a PR. Please link to this issue when you file the PR so we can close it.

On Thu, Feb 29, 2024, 07:42 areebfazli @.***> wrote:

Hello, Is this issue closed? Or can I work on it?

— Reply to this email directly, view it on GitHub https://github.com/JuliaLang/julia/issues/53348#issuecomment-1971060477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP5MDHG7HYY3GXLKAUX7GDYV4Q2TAVCNFSM6AAAAABDKPQ2ASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGA3DANBXG4 . You are receiving this because you commented.Message ID: @.***>

sjkelly avatar Feb 29 '24 13:02 sjkelly

The problem is not as simple as it seems because in the file index.md the link is using @ref as a reference. I can hardcode the working link https://pkgdocs.julialang.org/v1/creating-packages/#Adding-tests-to-the-package but I don't think that's the optimal solution as the other link on the page with the text "read about more here" has the same issue. The proper way to fix this is to change the definition of @ref but I cannot the location of that Can someone guide me about this?

Capture

areebfazli avatar Mar 01 '24 14:03 areebfazli

I think this can be closed; cref. https://github.com/JuliaLang/julia/pull/53509/files

xlxs4 avatar Jul 13 '24 11:07 xlxs4