julia icon indicating copy to clipboard operation
julia copied to clipboard

docs (prebuilt download renders buttons)

Open spaette opened this issue 2 years ago • 2 comments

Are prebuilt docs' rendering of buttons unintentional?

$ cd /tmp; tar xf julia-1.8.1-linux-x86_64.tar.gz
$ 

open in a graphical web browser the following

file:///tmp/julia-1.8.1/share/doc/julia/html/en/stdlib/Statistics.html

a source button appears when the mouse is placed over the section button

in this example the hyperlink on the button is to an online page's section

https://github.com/JuliaLang/Statistics-61a021bcb330e6c52f2435f2abaffc77875ab6f2/src/Statistics.jl#L422-L448

https://docs.julialang.org/en/v1/stdlib/Statistics/

no source button appears when the mouse is placed over the same section as appears in the screenshot

spaette avatar Sep 16 '22 22:09 spaette

Are prebuilt docs' rendering of buttons unintentional?

No, there should be a button.

https://docs.julialang.org/en/v1.9-dev/stdlib/Statistics/ 1.9-dev looks fine.

inkydragon avatar Sep 17 '22 10:09 inkydragon

It doesn't seem correct that releases should include buttons.

The 1st link I provided when opened in a browser tab returns the following.

Not Found

spaette avatar Sep 17 '22 21:09 spaette

julia-1.8.2-linux-x86_64.tar.gz

In this release likewise the hyperlink on the button is to an online page's section.

https://github.com/JuliaLang/Statistics-61a021bcb330e6c52f2435f2abaffc77875ab6f2/src/Statistics.jl#L422-L448

And the link when opened in a browser tab returns the following.

Not Found

That's the same link as in julia-1.8.1-linux-x86_64.tar.gz.

spaette avatar Oct 27 '22 15:10 spaette

1.9-dev looks fine.

on the 1,9-dev Statistics page the button's hyperlink when opened in a browser tab returns a 404

therefore my suggestion is to not include the buttons in the precompiled releases

spaette avatar Oct 31 '22 17:10 spaette

Perhaps this ticket should be labeled WON'T FIX and closed.

spaette avatar Dec 15 '22 18:12 spaette

Closed due to age.

spaette avatar Jan 05 '23 15:01 spaette