julia icon indicating copy to clipboard operation
julia copied to clipboard

Fix shift direction of circshift! for vectors

Open fredrikekre opened this issue 3 years ago • 4 comments

This patch fixes the shifting direction for circshift!(x::AbstractVector, n::Integer), which was opposite the direction of circshift(x, n) and circshift!(y, x, n). In addition, this patch fixes the method to also work correctly with offset arrays. Fixes #46533.

fredrikekre avatar Sep 14 '22 15:09 fredrikekre

I believe this will break some sparsearrays stuff. @Keno

gbaraldi avatar Sep 14 '22 15:09 gbaraldi

Yea, will have to fix there too. But hopefully this isn't used much in the ecosystem yet, it has only been in 1.8.0.

fredrikekre avatar Sep 14 '22 15:09 fredrikekre

@nanosoldier runtests(ALL, vs = ":master")

fredrikekre avatar Sep 14 '22 15:09 fredrikekre

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

nanosoldier avatar Sep 14 '22 21:09 nanosoldier