julia icon indicating copy to clipboard operation
julia copied to clipboard

removed the function as per SocketsIssues

Open advinsuryavanshi opened this issue 3 years ago • 1 comments

There is an additional method in Socketshttps://docs.julialang.org/en/v1/stdlib/Sockets/#Base.bind) that belongs to Tasks.

It is already there, but it should be removed from Sockets. changesfirst

advinsuryavanshi avatar Aug 08 '22 11:08 advinsuryavanshi

Why do you remove this method?

bind(c::Channel, task::Task)

julia> VERSION
v"1.8.0-rc3"

julia> methods(bind)
# 4 methods for generic function "bind":
[1] bind(c::Channel, task::Task) in Base at channels.jl:253
[2] bind(sock::Union{Sockets.TCPServer, Sockets.TCPSocket, Sockets.UDPSocket}, host::Sockets.IPAddr, port::Integer; ipv6only, reuseaddr, kws...) in Sockets at C:\Users\a309\AppData\Local\julias\julia-1.8\share\julia\stdlib\v1.8\Sockets\src\Sockets.jl:255
[3] bind(sock::Sockets.TCPServer, addr::Sockets.InetAddr) in Sockets at C:\Users\a309\AppData\Local\julias\julia-1.8\share\julia\stdlib\v1.8\Sockets\src\Sockets.jl:285
[4] bind(server::Sockets.PipeServer, name::AbstractString) in Sockets at C:\Users\a309\AppData\Local\julias\julia-1.8\share\julia\stdlib\v1.8\Sockets\src\PipeServer.jl:50

it should be removed from Sockets.

And Base.bind is belonged to Base

Doing this will break our build process:

ERROR: LoadError: Error when installing package JSON:
UndefVarError: bind not defined
Stacktrace:
 [1] Channel{Tuple{String, Vector{String}, Vector{String}}}(func::Base.Filesystem.var"#28#31"{String}, size::Int64; taskref::Nothing, spawn::Bool)
   @ Base ./channels.jl:136

https://buildkite.com/julialang/julia-master/builds/14605#01827d52-a445-403c-ab86-52ceb6bd33e1/3189-3220 image

inkydragon avatar Aug 09 '22 11:08 inkydragon