PackageCompiler.jl icon indicating copy to clipboard operation
PackageCompiler.jl copied to clipboard

add warning about threading issue

Open IanButterworth opened this issue 2 years ago • 2 comments

Fixes #778

IIUC in non-incremental (--sysimage=*.ji) mode with stdlibs filtered out, julia has to do a lot more bootstrapping, which may max out all available threads, so not maxing out all threads during each Pkg.precompile subprocess isn't guaranteed, so it's best to warn the user to just be conservative with enabling threading.

cc. @vtjnash

IanButterworth avatar Feb 02 '23 21:02 IanButterworth

Codecov Report

Merging #781 (0301e62) into master (8e4c03c) will decrease coverage by 0.10%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   83.00%   82.90%   -0.10%     
==========================================
  Files           3        3              
  Lines         665      667       +2     
==========================================
+ Hits          552      553       +1     
- Misses        113      114       +1     
Impacted Files Coverage Δ
src/PackageCompiler.jl 92.95% <50.00%> (-0.17%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Feb 02 '23 22:02 codecov[bot]

We should just fix this for real instead!

JeffBezanson avatar Feb 08 '23 16:02 JeffBezanson

I am pretty sure this is fixed!

sjkelly avatar Jun 25 '24 19:06 sjkelly