PackageCompiler.jl icon indicating copy to clipboard operation
PackageCompiler.jl copied to clipboard

`build` and then `precompile` in `ensurecompiled`

Open ven-k opened this issue 2 years ago • 3 comments

  • In certain cases like when Conda is invloved, the ensurecompiled fails if Conda isn't built properly.

ven-k avatar Mar 14 '22 07:03 ven-k

Codecov Report

Merging #672 (6965f42) into master (6a3bdcc) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   95.25%   95.25%           
=======================================
  Files           2        2           
  Lines         464      464           
=======================================
  Hits          442      442           
  Misses         22       22           
Impacted Files Coverage Δ
src/PackageCompiler.jl 95.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a3bdcc...6965f42. Read the comment docs.

codecov[bot] avatar Mar 14 '22 08:03 codecov[bot]

I would have thought https://github.com/JuliaLang/PackageCompiler.jl/blob/6a3bdcc13743ba5e94c814162a0b8d30a720eacb/src/PackageCompiler.jl#L450 would have built packages if they got downloaded.

KristofferC avatar Mar 14 '22 14:03 KristofferC

It's been a hit and miss. Most of the time it isn't an issue. But couple of times Conda wasn't built properly and resulted in failed create_sysimage

- PackageCompiler: compiling incremental system image
  | Precompiling project...
  | :
  | ✗ Conda
  | :
Conda [8f4d0f93-b110-5947-807f-2305c1781a2d]
--
  |  
  | Failed to precompile Conda [8f4d0f93-b110-5947-807f-2305c1781a2d] to depot/compiled/v1.6/Conda/jl_CYS8mf.
  | ERROR: LoadError: Conda is not properly configured.  Run Pkg.build("Conda") before importing the Conda module.
  | Stacktrace:
  l :
  | in expression starting at depot/packages/Conda/dICyM/src/Conda.jl:1
  | :
  | Stacktrace:
  | [1] pipeline_error
  | @ ./process.jl:525 [inlined]
  | [2] run(::Cmd; wait::Bool)
  | @ Base ./process.jl:440
  | [3] run
  | @ ./process.jl:438 [inlined]
  | [4] ensurecompiled(project::String, packages::Vector{String}, sysimage::String)
  | @ PackageCompiler

ven-k avatar Mar 15 '22 08:03 ven-k