MbedTLS.jl icon indicating copy to clipboard operation
MbedTLS.jl copied to clipboard

Add `parse_key` and `parse_public_key` methods

Open devmotion opened this issue 1 year ago • 3 comments

This PR adds MbedTLS.parse_key and MbedTLS.parse_public_key methods which are arguably convenient additions and complement MbedTLS.parse_key! and MbedTLS.parse_public_key! in the same way as MbedTLS.parse_keyfile/MbedTLS.parse_keyfile! and MbedTLS.parse_public_keyfile/MbedTLS.parse_public_keyfile!.

devmotion avatar Feb 12 '24 15:02 devmotion

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4c4de15) 76.49% compared to head (6184783) 76.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   76.49%   76.74%   +0.24%     
==========================================
  Files          12       12              
  Lines         753      761       +8     
==========================================
+ Hits          576      584       +8     
  Misses        177      177              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 17:02 codecov[bot]

Bump 🙂

devmotion avatar Feb 19 '24 21:02 devmotion

Who would be the right person to review this? @quinnj maybe?

DilumAluthge avatar Feb 19 '24 21:02 DilumAluthge