JuliaParser.jl icon indicating copy to clipboard operation
JuliaParser.jl copied to clipboard

De-unicodify internal API

Open tkelman opened this issue 8 years ago • 3 comments

This package isn't doing math, so isn't appropriate. The meaning on ¬ is pretty unconventional too, and ⨳, ⪥, ⤄ are tough to read. Would have been nice to open kf/loctrack as a PR for feedback before merging it into master.

diag should also be spelled out, otherwise it's not the same verb as the diagonal meaning used for that function in Base.

tkelman avatar Apr 01 '16 01:04 tkelman

I tend to agree, it is nice that it is terse for readability but at the same time it is much harder to edit and the non-combiner symbols are not intuitive at all.

jakebolewski avatar Apr 15 '16 00:04 jakebolewski

It would be nice to document all the functions including this ones, what ever identifier name they end up having. I'd like to improve overall documentation and add more examples.

Ismael-VC avatar Apr 15 '16 01:04 Ismael-VC

@Keno this was a great improvement, but to be honest the unicode symbols make me a bit sad. Have you thought about ASCII equivalents to these function names? It seems best to avoid code churn going forward if this is going to be part of the core infrastructure.

jakebolewski avatar Jul 11 '16 23:07 jakebolewski