Downloads.jl icon indicating copy to clipboard operation
Downloads.jl copied to clipboard

Allow setting global hooks to modify Easy object

Open habemus-papadum opened this issue 2 years ago • 4 comments

Provide a robust way to customize system download behavior (more robust in comparison to #207)

Todo

  • [x] Scan for typos, code style
  • [x] Add unit tests
  • [x] Add documentation
  • [x] Create sample usage that sets global - Timeout options - CA paths - rewrite urls

habemus-papadum avatar Oct 27 '22 12:10 habemus-papadum

Codecov Report

Merging #209 (57f08f1) into master (0098e40) will increase coverage by 0.34%. The diff coverage is 100.00%.

:exclamation: Current head 57f08f1 differs from pull request most recent head a30270e. Consider uploading reports for the commit a30270e to get more accurate results

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   90.26%   90.60%   +0.34%     
==========================================
  Files           5        5              
  Lines         575      596      +21     
==========================================
+ Hits          519      540      +21     
  Misses         56       56              
Impacted Files Coverage Δ
src/Downloads.jl 87.87% <100.00%> (+2.29%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 27 '22 12:10 codecov[bot]

Functionality and unit tests complete. If someone could have an initial glance, that would be much appreciated. Still needed: documentation

habemus-papadum avatar Oct 27 '22 18:10 habemus-papadum

added documentation

habemus-papadum avatar Nov 10 '22 12:11 habemus-papadum

I've rebased this PR. It should provide a more robust/composable solution to configuring systemwide download behavior. Any comments regarding the API would be welcome

habemus-papadum avatar Feb 01 '23 15:02 habemus-papadum