Julia Kukulies

Results 93 comments of Julia Kukulies

And good point with #175. I am almost inclined to say that we are OK with it due to the reasons that you mention (better sooner than later nudge users...

Hm, I am slightly confused @freemansw1. When I look at `feature_detection_multithreshold()` in `feature_detection.py` for `RC_v1.4.0` I can actually see the `dxy` parameter. Or did you mean `dxy=-1` in `feature_detection_multithreshold_timestep()`? I...

> We have a couple options for resolving that issue; we could simply output xarray if users input xarray rather than iris data. The issue there is that our users...

Would the easiest way to implement this be to specify a structure with [`scipy.ndimage.label`](https://docs.scipy.org/doc/scipy/reference/generated/scipy.ndimage.label.html) that connects segmented features that are continuous over the time dimension or would you rather write...

Totally agree on this. I would be in favor of removing them instead of having commented out code in the notebooks. As we integrate the example tutorials back into the...

Thanks for reporting, @freemansw1- I will have a look at this!

I just checked for all possible integers in the specified range (between `signal_min` and `matrix.shape[-1]`) if the test fails and I am actually not able to reproduce neither the fail...

OK, wild. Thanks for providing the details of your environment and machine! I tried `signal_idx = 4` in a few different conda environments and the tests always pass for me....

Given that `v2.0-dev` is pretty out-of-date and will most likely not really be used for the future development of version 2, can this issue be closed @freemansw1 ?

> BTW: I did not change protection and review rules for this experimental branch. Happy if somebody can point me to the place where this can be done ... The...