TaylorModels.jl icon indicating copy to clipboard operation
TaylorModels.jl copied to clipboard

Adds automatic display of bechmark results

Open aa25desh opened this issue 4 years ago • 7 comments

Look at issue #47

With this commit I am getting required results locally.

As relative precision is stored in RELPREC dictionary, which is not generated by PkgBenchmark. we would not get it automatically. @mforets Is there way to get relative precision?

Still there might be few things to be done by repository owner

  • Make sure to fix the version number in your CI setup.
  • Repo has permission to use Github on Action

aa25desh avatar Sep 15 '20 17:09 aa25desh

Thanks for the contribution @aa25desh

What do you mean by "relative precision"?

lbenet avatar Sep 15 '20 17:09 lbenet

This function measures the relative precision of the result in a more informative way than taking the scalar overestimation because it evaluates the precision of the lower and the upper range bounds separately. look here.

aa25desh avatar Sep 15 '20 17:09 aa25desh

@mforets Is there way to get relative precision?

i see, you'd like to store additional columns in the results table. i had a quick look and i'm not sure that feature is available in the user interface of PkgBenchmark.jl

mforets avatar Sep 15 '20 18:09 mforets

@lbenet should we find some workaround or is it ok for now?

aa25desh avatar Sep 15 '20 18:09 aa25desh

I think this PR is quite interesting; yet, I am not able to see any results; while I see that something is being triggered by github actions, there are no details since it is simply skipped.

@dpsanders @mforets What do you think about this? Shall we give it a try?

lbenet avatar Oct 15 '20 14:10 lbenet

from https://github.com/JuliaIntervals/TaylorModels.jl/pull/90/files#r490853817 we shall try run benchmark ? as a comment? i don't have previous experience with BenchmarkCI .

mforets avatar Oct 16 '20 12:10 mforets

we shall try run benchmark ? as a comment?

Yes as a comment in PR.

aa25desh avatar Oct 17 '20 16:10 aa25desh