Upgrade TaylorSeries to v0.18 and TaylorIntegration to v0.16

[lbenet]

[github-actions[bot]]

Pull Request Test Coverage Report for Build 10232509876

Details

• 353 of 434 (81.34%) changed or added relevant lines in 2 files are covered.
• 487 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-26.7%) to 53.426%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/valid_integ/validated_integ2.jl	109	142	76.76%
src/valid_integ/validated_integ.jl	244	292	83.56%
<!--	Total:	353	434

Files with Coverage Reduction	New Missed Lines	%
src/validatedODEs.jl	487	0.0%
<!--	Total:	487

Totals
Change from base Build 8638389233:	-26.7%
Covered Lines:	1037
Relevant Lines:	1941

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 10232509876

Details

• 353 of 434 (81.34%) changed or added relevant lines in 2 files are covered.
• 487 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-26.3%) to 53.786%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/valid_integ/validated_integ2.jl	109	142	76.76%
src/valid_integ/validated_integ.jl	244	292	83.56%
<!--	Total:	353	434

Files with Coverage Reduction	New Missed Lines	%
src/validatedODEs.jl	487	0.0%
<!--	Total:	487

Totals
Change from base Build 8638389233:	-26.3%
Covered Lines:	1037
Relevant Lines:	1928

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 12995972981

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 355 of 434 (81.8%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-2.1%) to 78.054%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/valid_integ/validated_integ2.jl	109	142	76.76%
src/valid_integ/validated_integ.jl	246	292	84.25%
<!--	Total:	355	434

Totals
Change from base Build 8638389233:	-2.1%
Covered Lines:	1035
Relevant Lines:	1326

---

💛 - Coveralls

[lbenet]

Closes #159 and #160

[lbenet]

The test that fails (only in Julia 1.6) is related to an ambiguity detected by Aqua; I'll ignore it for the time being...

[schillic]

Closes #159 and #160

FYI, if you want to auto-close these PRs, you need to put this text in the very first post. And GitHub does not understand "and", so you need to write "Closes" twice.

[lbenet]

Closes #159 and #160

FYI, if you want to auto-close these PRs, you need to put this text in the very first post. And GitHub does not understand "and", so you need to write "Closes" twice.

Thanks a lot for clarifying it!

[lbenet]

Mmmm, there seems to be some odity related to coveralls...

[schillic]

Mmmm, there seems to be some odity related to coveralls...

I have no experience with coveralls (we always use codecov). The error message is indeed not helpful.

Fixing the cause would of course be better, but maybe you can add the following line inside the with block here: https://github.com/JuliaIntervals/TaylorModels.jl/blob/bfc579131c4542b9f10b5455f2b0a26c1729f96f/.github/workflows/ci.yml#L52-L55

fail_ci_if_error: false

[lbenet]

@schillic I think this is ready to be merged (and tagged). Could you check that everything works fine wrt ReachabilityAnalysis ?

[schillic]

I got an error:

pkg> st
[...]
  [92b13dbe] TaylorIntegration v0.16.2
  [314ce334] TaylorModels v0.7.1 `https://github.com/JuliaIntervals/TaylorModels.jl.git#lb/upgrade_TS`
⌅ [6aa5eb33] TaylorSeries v0.18.4
[...]

pkg> test
[...]
  MethodError: no method matching _evaluate!(::TaylorN{IntervalArithmetic.Interval{Float64}}, ::HomogeneousPolynomial{IntervalArithmetic.Interval{Float64}}, ::Tuple{TaylorN{Float64}, TaylorN{Float64}}, ::Vector{TaylorN{Float64}}, ::TaylorN{IntervalArithmetic.Interval{Float64}})
  The function `_evaluate!` exists, but no method is defined for this combination of argument types.
  
  Closest candidates are:
    _evaluate!(::TaylorN{T}, ::HomogeneousPolynomial{T}, ::Int64, ::TaylorN{T}, ::TaylorN{T}) where T<:Union{Real, Complex, Taylor1}
     @ TaylorSeries ~/.julia/packages/TaylorSeries/Mdt5d/src/evaluate.jl:406
    _evaluate!(::TaylorN{T}, ::HomogeneousPolynomial{T}, ::NTuple{N, var"#s485"} where var"#s485"<:TaylorN{T}, ::Array{TaylorN{T}, 1}, ::TaylorN{T}) where {N, T<:Union{Real, Complex}}
     @ TaylorSeries ~/.julia/packages/TaylorSeries/Mdt5d/src/evaluate.jl:197
    _evaluate!(::TaylorN{T}, ::NTuple{N, TaylorN{T}}, ::TaylorN{T}, ::Array{TaylorN{T}, 1}, ::TaylorN{T}) where {N, T<:Number}
     @ TaylorSeries ~/.julia/packages/TaylorSeries/Mdt5d/src/evaluate.jl:501

[schillic]

Do you need an input to debug or is it clear what causes the problem?

[lbenet]

I'll have a look to see if I can reproduce the problem...

[lbenet]

@schillic I can reproduce the error; can you tell me which was the last version (of TS) that allowed the tests to pass. Perhaps the reason for the problem is that I forgot to include a method that is precisely needed here.

[schillic]

This branch only allows v0.18.4. And the last release allows v0.17.8, for which tests passed.

[lbenet]

I think I found the problem... Can you test again using for TS the branch in https://github.com/JuliaDiff/TaylorSeries.jl/pull/378 ? (Locally, tests pass, but I prefer to have your confirmation.)

[lbenet]

@schillic I juste merged https://github.com/JuliaDiff/TaylorSeries.jl/pull/378; bumping the patch version is on its way. Once that is done, I think I can merge this PR

[schillic]

I was too slow debugging something else, but now I re-ran the tests with your branch and indeed they pass :+1:

[lbenet]

Thanks a lot Christian! I guess I have to tag a minor version, right?