libcxxwrap-julia icon indicating copy to clipboard operation
libcxxwrap-julia copied to clipboard

Added the Iterator wrapper

Open abdoei opened this issue 1 year ago • 4 comments

https://github.com/JuliaInterop/CxxWrap.jl.git

(I added the above line because this is needed by CI now - Bart)

I have added the iterator wrapper support for the STL containers [with one argument template] and edited the StdDeque container to be used with it and added the constructor of the Deque that takes size_type count, const T& value = T(), const Allocator& alloc = Allocator(), tested it on Julia, and it worked as expected

abdoei avatar Sep 23 '23 18:09 abdoei

@abdoei The Mac compile error is something that needs to be fixed: https://github.com/JuliaInterop/libcxxwrap-julia/actions/runs/6285226887/job/17138204435?pr=133#step:4:70

barche avatar Sep 26 '23 12:09 barche

could you review this pr please

abdoei avatar Apr 20 '24 16:04 abdoei

Currently all tests are failing, I think because the std::deque iteratorbegin method requires the wrapper type to be defined first. I think you need a two-staged approach here, where you first add the wrapper type itself and only then add its methods, or first add the deque type, then add the wrapper and its methods, and then add the deque methods.

barche avatar Apr 28 '24 19:04 barche

I opened a PR on the Julia part that contains the tests and all worked well on my machine

abdoei avatar May 04 '24 01:05 abdoei

This is now integrated in https://github.com/JuliaInterop/libcxxwrap-julia/pull/170

barche avatar Jul 21 '24 14:07 barche