RCall.jl icon indicating copy to clipboard operation
RCall.jl copied to clipboard

REPL completion fix on 1.12

Open palday opened this issue 8 months ago • 2 comments

Multiple sources of breakage

  • https://github.com/JuliaLang/julia/pull/54800; fix adapted from https://github.com/JuliaLang/IJulia.jl/pull/1147
  • https://github.com/JuliaLang/julia/pull/57192; some related discussion https://github.com/JuliaLang/julia/issues/58189

Seems like #588 also helped with calling the function pointers from a background thread!

palday avatar Apr 18 '25 20:04 palday

Codecov Report

:x: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 85.08%. Comparing base (0324da9) to head (3651b77).

Files with missing lines Patch % Lines
src/RPrompt.jl 82.22% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   85.34%   85.08%   -0.27%     
==========================================
  Files          26       26              
  Lines        1713     1730      +17     
==========================================
+ Hits         1462     1472      +10     
- Misses        251      258       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 18 '25 20:04 codecov[bot]

Looks like multiple causes. Additional bisection leads to:

0b9525bf81a1727e18d3342a6da7f8505bc447f5 is the first bad commit
commit 0b9525bf81a1727e18d3342a6da7f8505bc447f5
Author: Ian Butterworth <[email protected]>
Date:   Fri Jan 31 12:08:26 2025 -0500

    REPL: generate tab completion hints on a worker thread to not block typing (#57192)

 stdlib/REPL/src/LineEdit.jl | 110 +++++++++++++++++++++++++++++---------------
 stdlib/REPL/src/REPL.jl     |  10 ++--
 2 files changed, 79 insertions(+), 41 deletions(-)

https://github.com/JuliaLang/julia/pull/57192

palday avatar Apr 22 '25 05:04 palday