ImageDraw.jl icon indicating copy to clipboard operation
ImageDraw.jl copied to clipboard

Filled Polygon Option

Open opiateblush opened this issue 2 years ago • 2 comments

  • added simple fill option for polygons, similar to the filled ellipse
  • the polygon's boundary must be drawn even in the filled case, as the scanline filling algorithm cannot handle multiple vertices on a straight line

opiateblush avatar Jul 12 '22 12:07 opiateblush

this might partly solve #53

opiateblush avatar Jul 12 '22 13:07 opiateblush

@ashwani-rathee can you help review this?

johnnychen94 avatar Jul 12 '22 13:07 johnnychen94

It's been quite some time, is there any problem with my implementation? I'm fairly new to the pull request business, so I hope it's ok to ask if there is something wrong.

opiateblush avatar Apr 18 '23 15:04 opiateblush

This PR would be very useful for us to fill contours, instead of PyCalling to skimage.draw polygon of our current approach. I have tested on our data, it works and looks identical to the result using skimage.

babaq avatar Aug 10 '23 20:08 babaq

Let me review this today, we should have this soon

ashwanirathee avatar Aug 11 '23 02:08 ashwanirathee

Can we merge this branch and tag a new release, seems straightforward to review the small amount of code change.

babaq avatar Aug 20 '23 20:08 babaq

Give me 2-3 days time, I'll review and we can get a new version asap

ashwanirathee avatar Aug 21 '23 05:08 ashwanirathee

Those commits were from me, btw. Unfortunately, i made them with a different account, which I usually use for work stuff.

opiateblush avatar Sep 25 '23 13:09 opiateblush