ImageCore.jl icon indicating copy to clipboard operation
ImageCore.jl copied to clipboard

Restrict clamp01 to gray & RGB

Open timholy opened this issue 3 years ago • 4 comments

The 0-to-1 colorscale does not have meaning for colors like HSV, so supporting arbitrary colorants seems wrong.

I noticed this while working on https://github.com/JuliaImages/FluorophoreColors.jl/pull/4. We might not want to merge this until we decide to make a push for the next breaking release.

timholy avatar May 13 '22 11:05 timholy

Have you noticed the CI failure previously? It happens on master too. I haven't delved deeply to see what changed it, but from a quick debug it has to do with using the typeinfo in display, i.e., https://github.com/JuliaGraphics/ColorTypes.jl/blob/b8ed378531f1445ed2402a00d49ecbf64ce5a0fc/src/show.jl#L11-L18. What puzzles me is that this isn't new. Maybe there was some dependency change?

I think the new way of printing is nicer so wondering if we should change the docstring, but it would be nice to know what dependency changed so we can add it to the [compat].

timholy avatar May 14 '22 11:05 timholy

It's because you've made a ColorTypes release v0.11.1 4 days ago and shipped every commit before that https://github.com/JuliaGraphics/ColorTypes.jl/commit/b8ed378531f1445ed2402a00d49ecbf64ce5a0fc#comments 😆

I guess @kimikage planned a bigger release v0.12 or so. BTW, I'm wondering what happened to him; haven't seen him active for quite a long time. Hope he's still okay.

johnnychen94 avatar May 14 '22 12:05 johnnychen94

Oh shoot. I didn't check how much was on master, big mistake.

I will try to fix this. I think the best plan is to fork a release 0.11 branch, backport my recent commit, and release 0.11.2. Reasonable?

timholy avatar May 15 '22 09:05 timholy

Codecov Report

Merging #181 (ad9bcc8) into master (9e64fec) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   62.60%   62.60%           
=======================================
  Files          10       10           
  Lines         583      583           
=======================================
  Hits          365      365           
  Misses        218      218           
Impacted Files Coverage Δ
src/map.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e64fec...ad9bcc8. Read the comment docs.

codecov[bot] avatar May 15 '22 10:05 codecov[bot]