ImageCore.jl icon indicating copy to clipboard operation
ImageCore.jl copied to clipboard

Move to BenchmarkCI?

Open timholy opened this issue 5 years ago • 3 comments

https://github.com/JuliaImages/ImageFiltering.jl/pull/150 reorganized the benchmarks for ImageFiltering into a form that would run on each PR and report results separately from tests. To me this seems more useful than the strategy currently used here, where the benchmarks run but failures are reported as warnings. We could consider switching to BenchmarkCI.

timholy avatar Jan 27 '20 10:01 timholy

There're still some issues to be fixed before the wide usage of BenchmarkCI, e.g, PRs from other forks don't trigger that, CI script doesn't get auto-updates. I prefer to fix them upstream first, and then apply to JuliaImages.

johnnychen94 avatar Jan 27 '20 10:01 johnnychen94

The current benchmark script seems to only benchmark getindex and setindex for channelview and colorview. What's other things you have in mind that definitely worth a benchmark?

johnnychen94 avatar Mar 08 '20 09:03 johnnychen94

Those alone are quite good, and already highlight areas that need fixing (ReinterpretArray has been a bit of a problem child). Perhaps we can add the various functions in src/map.jl. That may be about it, though.

timholy avatar Mar 12 '20 09:03 timholy