Zarr.jl icon indicating copy to clipboard operation
Zarr.jl copied to clipboard

Fix reading complex type and add basic round trip test

Open nhz2 opened this issue 9 months ago • 1 comments

This PR adds some basic round trip tests, which caught a bug in how complex numbers are read.

The test/python.jl file tests that zarr-python is able to read data from Zarr.jl. This PR adds some tests that Zarr.jl is able to read data from Zarr.jl.

nhz2 avatar Mar 07 '25 22:03 nhz2

Pull Request Test Coverage Report for Build 17166774584

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.4%) to 88.487%

Totals Coverage Status
Change from base Build 13680422725: 2.4%
Covered Lines: 953
Relevant Lines: 1077

💛 - Coveralls

coveralls avatar Mar 07 '25 22:03 coveralls

Bump

nhz2 avatar Apr 22 '25 22:04 nhz2

Why did

sizemapf(x::Type{<:Complex{T}}) where T = sizeof(T)

exist before?

mkitti avatar Aug 22 '25 19:08 mkitti

I think a typo. Also, what numpy calls complex64, Julia calls ComplexF32, so that might be part of the confusion. https://numpy.org/doc/stable/reference/arrays.interface.html#type-description-examples

nhz2 avatar Aug 22 '25 19:08 nhz2