Fix reading complex type and add basic round trip test
This PR adds some basic round trip tests, which caught a bug in how complex numbers are read.
The test/python.jl file tests that zarr-python is able to read data from Zarr.jl. This PR adds some tests that Zarr.jl is able to read data from Zarr.jl.
Pull Request Test Coverage Report for Build 17166774584
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+2.4%) to 88.487%
| Totals | |
|---|---|
| Change from base Build 13680422725: | 2.4% |
| Covered Lines: | 953 |
| Relevant Lines: | 1077 |
💛 - Coveralls
Bump
Why did
sizemapf(x::Type{<:Complex{T}}) where T = sizeof(T)
exist before?
I think a typo. Also, what numpy calls complex64, Julia calls ComplexF32, so that might be part of the confusion.
https://numpy.org/doc/stable/reference/arrays.interface.html#type-description-examples