Zarr.jl icon indicating copy to clipboard operation
Zarr.jl copied to clipboard

add support for symbols as keys

Open alex-s-gardner opened this issue 1 year ago • 6 comments

This adds support for symbol indexing into a ZGroup

alex-s-gardner avatar Nov 27 '23 17:11 alex-s-gardner

Pull Request Test Coverage Report for Build 7008504781

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 87.067%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ZGroup.jl 1 3 33.33%
<!-- Total: 1 3
Totals Coverage Status
Change from base Build 6484107136: -0.2%
Covered Lines: 754
Relevant Lines: 866

💛 - Coveralls

coveralls avatar Nov 27 '23 17:11 coveralls

Doc errors appear unrelated to this PR

alex-s-gardner avatar Nov 27 '23 17:11 alex-s-gardner

Thanks a lot for preparing this. I just looked at it and really like the idea to make the interface more DataFrame-like. I got carried away a bit and implemented dot syntax for subsetting as well so that you can use g.a to access array "a" from group g. Autocompletion works as well which should make working with groups much more ergonomic. However, this would technically be breaking because an array name might shadow the name of field of ZGroup so I had to define some accessors to disambiguate.

Could you have a look if this works for you?

meggart avatar Nov 30 '23 08:11 meggart

Pull Request Test Coverage Report for Build 7043631258

  • 47 of 56 (83.93%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 87.177%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ZGroup.jl 33 42 78.57%
<!-- Total: 47 56
Files with Coverage Reduction New Missed Lines %
src/ZGroup.jl 1 84.16%
<!-- Total: 1
Totals Coverage Status
Change from base Build 6484107136: -0.09%
Covered Lines: 775
Relevant Lines: 889

💛 - Coveralls

coveralls avatar Nov 30 '23 08:11 coveralls

Pull Request Test Coverage Report for Build 7113230225

  • 55 of 55 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 88.501%

Totals Coverage Status
Change from base Build 6484107136: 1.2%
Covered Lines: 785
Relevant Lines: 887

💛 - Coveralls

coveralls avatar Dec 01 '23 10:12 coveralls

in the depths of AGU prep right now but will review this asap

alex-s-gardner avatar Dec 01 '23 18:12 alex-s-gardner