Add VideoIO.framerate(f) to the manual and expand tests
Related to #392
Todo:
- [x] Add expected values tests for example videos
- [x] Add generated video tests with more fps values
cc. @AbelHo
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 77.82%. Comparing base (1e0dca4) to head (acd7a18).
:warning: Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
+ Coverage 77.70% 77.82% +0.11%
==========================================
Files 10 10
Lines 1310 1308 -2
==========================================
Hits 1018 1018
+ Misses 292 290 -2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
results from this https://github.com/JuliaIO/VideoIO.jl/pull/393/commits/7f2c7173addc2f2cc31594bca4512bae8e7049e0 :
julia> VideoIO.framerate.(VideoIO.openvideo.(fnames))
5-element Vector{Rational{Int32}}:
1//90000
1//12800
1//15360
1//1000
1//25000
julia> map(fnames) do x
vid=VideoIO.openvideo(x); read(vid); VideoIO.framerate(vid)
end
5-element Vector{Rational{Int32}}:
1//90000
1//12800
1//15360
1//1000
1//25000
julia> get_fps.(fnames)
5-element Vector{Rational{Int64}}:
30//1
25//1
30//1
25//1
25//1
@AbelHo @f3fora would you mind reviewing this. I can't see why the tests are failing
Bump @AbelHo (I saw the thumbs up. Thanks!)
Bump. Help would be appreciated 🙏