ProtoBuf.jl icon indicating copy to clipboard operation
ProtoBuf.jl copied to clipboard

Remove TranscodingStreams dependency

Open nhz2 opened this issue 1 year ago • 1 comments

I'm not sure why TranscodingStreams is a dependency of this package.

Both uses in:

https://github.com/JuliaIO/ProtoBuf.jl/blob/3eb59e1cf4e9bb014fbdea201b40fe265cee79d4/src/codec/vbyte.jl#L2-L4

and

https://github.com/JuliaIO/ProtoBuf.jl/blob/3eb59e1cf4e9bb014fbdea201b40fe265cee79d4/src/lexing/Lexers.jl#L48

are relying on internal details of TranscodingStreams that may break in the future at any time.

Ref: https://github.com/JuliaLang/julia/pull/49125

nhz2 avatar Jul 03 '24 03:07 nhz2

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.99%. Comparing base (3eb59e1) to head (bcc6c0b).

Files Patch % Lines
src/codec/vbyte.jl 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   92.96%   92.99%   +0.03%     
==========================================
  Files          25       25              
  Lines        2813     2812       -1     
==========================================
  Hits         2615     2615              
+ Misses        198      197       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 03 '24 03:07 codecov[bot]

This seems to be indirectly causing some issues. Ref: https://github.com/JuliaIO/TranscodingStreams.jl/issues/234

nhz2 avatar Jul 27 '24 20:07 nhz2