MAT.jl icon indicating copy to clipboard operation
MAT.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaIO

v4 support

Open vsaase opened this issue 5 years ago • 5 comments
trafficstars

Hi, this provides v4 support. I am not yet very experienced with Julia so it might be a bit rough. Comments welcome.

vsaase avatar Dec 12 '19 22:12 vsaase

Is this good to go?

musm avatar Sep 04 '20 04:09 musm

I think so. The tests with the set of MAT4 files, which use all functionality of MAT4, passed.

vsaase avatar Sep 04 '20 14:09 vsaase

This is causing some test failures I think on Julia 1.5.1 on MacOS for some reason: https://travis-ci.org/github/JuliaIO/MAT.jl/jobs/724195833

I'm not sure why exactly this is Mac specific.

musm avatar Sep 04 '20 15:09 musm

Actually that error doesn't look related.

musm avatar Sep 04 '20 15:09 musm

I guess the only thing I'm not a big fan of is naming it matwrite4

can we not make it kwarg so we can consolidate them all.

musm avatar Sep 17 '20 02:09 musm

Supplanted by #186. Thanks for getting the ball rolling here!

sjkelly avatar Jun 07 '23 13:06 sjkelly