JLD.jl icon indicating copy to clipboard operation
JLD.jl copied to clipboard

Make `T{typeof(f)}()` `load`able again

Open kshramt opened this issue 8 years ago • 2 comments

This patch fixes a regression introduced by 94af823c621a9e5cb5fcd8af1c364a2f3197ce22. Now the return value of Optim.optimize is loadable again.

kshramt avatar Feb 11 '17 07:02 kshramt

CI failures seem to be unrelated.

kshramt avatar Feb 11 '17 08:02 kshramt

This should be fixed with a custom Symbol printer at locations such as https://github.com/kshramt/JLD.jl/blob/071d0e16d3d44a0f29e5f0d9b1126246e4d1694e/src/JLD.jl?utf8=✓#L1127 which prints out getfield(mod.path, Symbol("name")) instead of mod.path.name when name can't be represented as a Symbol. (for bonus points, it could also write mod.path.#sin as typeof(mod.path.sin), but that's not strictly necessary).

vtjnash avatar Jul 17 '17 22:07 vtjnash