FFMPEG.jl icon indicating copy to clipboard operation
FFMPEG.jl copied to clipboard

modified: Project.toml Caret needed for v>1.0. Version 0.4.2.

Open hustf opened this issue 3 years ago • 1 comments

The compat entry was overly restrictive. A caret is needed since the binary has version >1.0.

See https://pkgdocs.julialang.org/v1/compatibility/#compat-pre-1.0

Ref #45. Not allowing FFMPEG 4.4 lead to cascading downgrades when combining with Plots and other packages.

hustf avatar Jun 21 '21 15:06 hustf

Codecov Report

Merging #46 (98d3368) into master (a819cde) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 98d3368 differs from pull request most recent head 4cfb756. Consider uploading reports for the commit 4cfb756 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           44        36    -8     
=========================================
- Hits            44        36    -8     
Impacted Files Coverage Δ
src/FFMPEG.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a819cde...4cfb756. Read the comment docs.

codecov[bot] avatar Jun 21 '21 15:06 codecov[bot]

I'm missing the point of this PR.

A caret is needed since the binary has version >1.0.

Caret is the default anyway: https://pkgdocs.julialang.org/v1/compatibility/#Version-specifier-format.

Not allowing FFMPEG 4.4

FFMPEG_jll 4.4 is very much allowed:

(@v1.12) pkg> st -m FFMPEG FFMPEG_jll
Status `~/.julia/environments/v1.12/Manifest.toml`
  [c87230d0] FFMPEG v0.4.1
⌅ [b22a6f82] FFMPEG_jll v4.4.2+2
Info Packages marked with ⌅ have new versions available but compatibility constraints restrict them from upgrading. To see why use `status --outdated -m`

giordano avatar Aug 30 '24 16:08 giordano