JuliaIO
Allow to specify module for resolving names
Add optional parameter to BSON.load function to specify module for resolving names. Solves https://github.com/MikeInnes/BSON.jl/issues/25 other than not updating the @load macro.
I am pretty new to Julia and Git and Github and PR’s… so if there are things I should do different or improve on the PR please let me know. The PR works for my uses, but I don’t know if it is how MikeInnes wants to approach it.
1 year has passed since the pull request. Maybe this repository should be cloned and made as new, forked project? (If its so dead now)
@CarloLucibello @DhairyaLGandhi Can we merge this? It is blocking pre-trained weights from being used in Metalhead without the user loading Zygote in the REPL.
yes this would be great to have. Maybe that review comment about a possible switch to init=@__MODULE__ could be ignored so that we don't risk breaking things (although I don't have a clear understanding of the consequences, maybe @__MODULE__ could provide a better default in the future).
Also, having tests would be nice if someone is willing to provide them, otherwise, this should not block the much more important work for Metalhead.
@timotaularson Sorry for the long delay. Do you mind adding the tests? Or I can take over and re-submit this PR, but I always like to preserve authorship for the people who take the effort to contribute.
Thank you for looking at this. I am very busy right now, and would be grateful if you could add tests, do the suggested rename, etc. as you see fit.
--Tim
On Mon, Mar 1, 2021, 9:34 PM Kyle Daruwalla [email protected] wrote:
@timotaularson https://github.com/timotaularson Sorry for the long delay. Do you mind adding the tests? Or I can take over and re-submit this PR, but I always like to preserve authorship for the people who take the effort to contribute.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaIO/BSON.jl/pull/28#issuecomment-788530046, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKRBP5FHF7DMRCGRMAIUSX3TBRFDRANCNFSM4GYYKJWA .