UpROOT.jl icon indicating copy to clipboard operation
UpROOT.jl copied to clipboard

Switch to PythonCall.jl?

Open Moelf opened this issue 1 year ago • 4 comments

@ianna reported installing this pkg breaks a bunch of things in her environment

Moelf avatar Sep 30 '24 09:09 Moelf

PythonCall still seems to have trouble with Julia multi-threading (well, PyCall can have too, but it seems worse with PythonCall). So I'm not sure ... question is, do we need UpROOT long-term at all, now that UnROOT is already quite mature (and with UpROOT having no writing API anyway) and now that we have a working ROOT wapper package again? Or should we just recommend that users, if UnROOT can't handle their use case yet, use Python uproot via PyCall or PythonCall directly or use the ROOT wrapper?

oschulz avatar Sep 30 '24 09:09 oschulz

PythonCall still seems to have trouble with Julia multi-threading (well, PyCall can have too, but it seems worse with PythonCall). So I'm not sure ... question is, do we need UpROOT long-term at all, now that UnROOT is already quite mature (and with UpROOT having no writing API anyway) and now that we have a working ROOT wapper package again? Or should we just recommend that users, if UnROOT can't handle their use case yet, use Python uproot via PyCall or PythonCall directly or use the ROOT wrapper?

if there aren't any users, I'd suggest to remove it from Package Registrator (if such thing is possible).

ianna avatar Sep 30 '24 09:09 ianna

if UnROOT can't handle their use case yet, use Python uproot via PyCall or PythonCall directly or use the ROOT wrapper?

I'm fine with this.

if there aren't any users, I'd suggest to remove it from Package Registrator (if such thing is possible).

can't really do that but we can make like a "stub“ release, where it doesn't do anything just make an error message. Or we can make it minimally useful .... can't be too hard

Moelf avatar Sep 30 '24 09:09 Moelf

I'd suggest to remove it from Package Registrator (if such thing is possible).

It's not - that would also very much go against the concept of reproducible computation that Pkg gives us. :-)

But we can mention that the package is deprecated in GitHub and in the README, and - some packages have done something like that - release a new version that also prints a log info message to that effect then the package is loaded.

oschulz avatar Sep 30 '24 09:09 oschulz