Make `algorithm` argument mandatory in `jet_reconstruct`
This is a breaking change
The algorithm keyword argument will be mandatory in jet_reconstruct, which effectively removes calling jet_reconstruct with power. The power will be still a keyword argument:
- required for generalized algorithms (GenKt and EEKt)
- ignore by other algorithms (appropriate power will be assigned internally instead of using the value from argument)
This allows to simplify the logic a bit and also will be easier to support in C-bindings #88
A few internal functions are removed. The internal algorithm2power dictionary now maps both pp and ee algorithms to their power, dictionary going in opposite direction is removed
Internal algorithms (_plain_jet_reconstruct etc) assume that algorithm and p given to them is consistent and won't check it or resolve again
Closes #129
CI fails to setup the Julia actions
Warning: Failed to download action 'https://api.github.com/repos/julia-actions/setup-julia/tarball/5c9647d97b78a5debe5164e9eec09d653d29bd71'. Error: Response status code does not indicate success: 504 (Gateway Timeout).
Warning: Back off 20.944 seconds before retry.
Error: Response status code does not indicate success: 504 (Gateway Timeout).
I think it's something with GitHub as I can download the links they can't without issues
OK looks like it was temporary outage
Codecov Report
Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
Project coverage is 74.96%. Comparing base (
8a91752) to head (968c983). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/GenericAlgo.jl | 66.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 75.23% 74.96% -0.28%
==========================================
Files 20 20
Lines 1284 1270 -14
==========================================
- Hits 966 952 -14
Misses 318 318
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.