Graphs.jl icon indicating copy to clipboard operation
Graphs.jl copied to clipboard

Test on LTS and pre-release with new syntax 'lts' and 'pre'

Open gdalle opened this issue 1 year ago • 3 comments

The new syntax 'lts' and 'pre' for GitHub actions adapts to the current LTS and pre-release versions. Pre-release is much more stable than nightly when it exists, so it's a good place to check for future issues

gdalle avatar Jul 18 '24 07:07 gdalle

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.30%. Comparing base (aa3d197) to head (b993f9d). Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   97.31%   97.30%   -0.01%     
==========================================
  Files         120      117       -3     
  Lines        6953     6948       -5     
==========================================
- Hits         6766     6761       -5     
  Misses        187      187              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 18 '24 07:07 codecov[bot]

JET complains because of traits

gdalle avatar Jul 25 '24 07:07 gdalle

Isn't v1.10 the new lts? In that case we should still keep the check for the lower bound version v1.6 until we decide to raise that version in Project.toml.

simonschoelly avatar Oct 20 '24 07:10 simonschoelly

Agreed, I'll open a separate PR to bump the compat

gdalle avatar Nov 06 '24 10:11 gdalle

I made the JET tests slightly less sensitive (:typo pass instead of :basic pass) until we figure out the trait union split. See https://aviatesk.github.io/JET.jl/dev/jetanalysis/#JET.JETAnalyzer

gdalle avatar Nov 06 '24 10:11 gdalle

@simonschoelly this is a very small change but it is necessary for the tests in 1.11 to actually be informative instead of always failing. If you have no objections I'd like to merge it?

gdalle avatar Nov 10 '24 21:11 gdalle