Graphs.jl icon indicating copy to clipboard operation
Graphs.jl copied to clipboard

Create some new options for `BFSIterator`

Open Tortar opened this issue 1 year ago • 2 comments

Fixes https://github.com/JuliaGraphs/Graphs.jl/issues/288.

This PR adds 2 new options, which can be useful when iterating in BFS:

  • depth_limit: specify the maximum level at which BFS should stop beforehand.
  • neighbors_type: specify which function to use when iterating in BFS, e.g. sometimes using inneighbors could be useful and this allows that

Tortar avatar Jun 26 '24 19:06 Tortar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.31%. Comparing base (ec6ab1b) to head (9e814be). Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         120      120           
  Lines        6953     6956    +3     
=======================================
+ Hits         6766     6769    +3     
  Misses        187      187           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 26 '24 20:06 codecov[bot]

Bump, I have some use cases for this, it should be easy to review

Tortar avatar Jul 12 '24 23:07 Tortar

Can someone take a look?

Tortar avatar Sep 25 '24 15:09 Tortar

let me know if you have more review suggestions @gdalle and thank you for taking a look!

Tortar avatar Sep 26 '24 01:09 Tortar

Let me know if there is still something to address @gdalle

Tortar avatar Sep 28 '24 10:09 Tortar

If you could release a new version with this I would be grateful so that I can use it in another package

Tortar avatar Sep 28 '24 10:09 Tortar