GraphIO.jl icon indicating copy to clipboard operation
GraphIO.jl copied to clipboard

remove Requires

Open GiggleLiu opened this issue 2 years ago • 3 comments

Remove conditional dependencies.

# GraphIO alone
julia> @time using GraphIO
  1.376940 seconds (3.12 M allocations: 221.025 MiB, 2.51% gc time, 32.49% compilation time)
# Remove Requires and restart
julia> @time using GraphIO
  1.775102 seconds (3.73 M allocations: 253.879 MiB, 2.98% gc time, 44.93% compilation time)

GiggleLiu avatar Oct 27 '21 08:10 GiggleLiu

is there any reason why this is not merged ? Is there any other plans for the future design of this package ?

filchristou avatar Mar 04 '22 09:03 filchristou

I guess nobody had time yet. In any case, it is something that needs to be discussed anyway, as there was a reason why we added Requires - I can't exactly rembember why, although I was the one who did the changes.

It is also nothing urgent, as no bugs are fixed and no new features are added.

simonschoelly avatar Mar 04 '22 09:03 simonschoelly

I guess nobody had time yet. In any case, it is something that needs to be discussed anyway, as there was a reason why we added Requires - I can't exactly rembember why, although I was the one who did the changes.

It is also nothing urgent, as no bugs are fixed and no new features are added.

I fix it because there are a lot bugs, I just can not load graph6 module. And keno find the similar bug. Well, I forgot to mention those bugs in the pr.

GiggleLiu avatar Mar 04 '22 14:03 GiggleLiu

This should probably be done with extensions now

gdalle avatar Jun 23 '23 08:06 gdalle

yes, can we close this ?

filchristou avatar Nov 16 '23 15:11 filchristou