QML.jl icon indicating copy to clipboard operation
QML.jl copied to clipboard

Screen -> MakieScreen (abstract type)

Open asinghvi17 opened this issue 1 year ago • 2 comments

asinghvi17 avatar Feb 19 '24 12:02 asinghvi17

Is this all it takes to support the latest Makie? If so, that would be great news :)

barche avatar Feb 20 '24 07:02 barche

I tried this patch, and the tests for QML.jl pass.

Unfortunately, the Makie examples from https://github.com/barche/QmlJuliaExamples don't seem to work. I tried opengl/makie.jl and opengl/makie-plot.jl, both failed with this error message:

MethodError: no method matching GLMakie.GLAbstraction.ShaderCache()

Closest candidates are:
  GLMakie.GLAbstraction.ShaderCache(::Any, ::Dict{String, Vector{String}}, ::Dict{String, Dict{Any, GLMakie.GLAbstraction.Shader}}, ::Dict{Any, GLMakie.GLAbstraction.GLProgram})
   @ GLMakie ~/.julia/packages/GLMakie/Wvj4h/src/GLAbstraction/GLShader.jl:90
  GLMakie.GLAbstraction.ShaderCache(::Any, ::Any, ::Any, ::Any)
   @ GLMakie ~/.julia/packages/GLMakie/Wvj4h/src/GLAbstraction/GLShader.jl:90
  GLMakie.GLAbstraction.ShaderCache(::Any)
   @ GLMakie ~/.julia/packages/GLMakie/Wvj4h/src/GLAbstraction/GLShader.jl:97

marcom avatar May 23 '24 15:05 marcom