Colors.jl icon indicating copy to clipboard operation
Colors.jl copied to clipboard

Switch to SnoopPrecompile

Open timholy opened this issue 3 years ago • 3 comments

On my machine, the workload inside the @precompile_all_calls goes from 0.3s with the previous precompile script to 0.08s with the new one, a 4x reduction. Given that we don't have precompiles anymore in ColorTypes (see https://github.com/JuliaGraphics/ColorTypes.jl/issues/270, a decision I agree with), this package seems like a good place to have some.

Measurements conducted on something like nightly but it should be applicable to the upcoming Julia 1.9.

timholy avatar Jan 04 '23 15:01 timholy

Codecov Report

Base: 98.82% // Head: 98.82% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (ac20a14) compared to base (b0d1b59). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          10       10           
  Lines        1274     1275    +1     
=======================================
+ Hits         1259     1260    +1     
  Misses         15       15           
Impacted Files Coverage Δ
src/Colors.jl 100.00% <ø> (ø)
src/precompile.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 04 '23 15:01 codecov[bot]

On nightly, I can't detect any difference in load time between master and this branch: master is 0.189s, this branch is 0.186s.

timholy avatar Jan 04 '23 15:01 timholy

This will likely be merged, but in any case it's PrecompileTools now.

kimikage avatar May 01 '24 11:05 kimikage